search

astefanutti / kubebox

⎈❏ Terminal and Web console for Kubernetes
http://astefanutti.github.io/kubebox
MIT License
2.14k stars 142 forks source link

Add search filter when displaying namespaces Fixes #15 and #49 #65

Closed johnpoth closed 4 years ago

johnpoth commented 4 years ago

Fixes #15 and fixes #49.

Adds search bar to namespace selection. Search is triggered when user starts typing. Further improvements might include highlighting match.

Thanks!

astefanutti commented 4 years ago

I've thought a bit about the best way to integrate the filter and come up with: Kubebox - namespaces filter It's a bit more UI work, but that would solve some of the issues mentioned above. Besides, it'd make obvious for users that filtering is possible.

WDYT?

johnpoth commented 4 years ago

Excellent feedback ! I think we can definitely afford having an extra field for Search. Let me work some magic and update this PR

astefanutti commented 4 years ago

Cool, I think we'll be able to generalise the work done for the namespaces and reuse it so that we can provide filtering for other widgets like pods, logs, ...

johnpoth commented 4 years ago

PR updated, lint errors may apply

astefanutti commented 4 years ago

It seems the PR hasn't picked up the changes. I think the PR was created from your fork, while you've pushed the branch to this repository. Would you mind pushing to your fork as well?

johnpoth commented 4 years ago

PR updated

johnpoth commented 4 years ago

@astefanutti I've push some changes to address some sizing issues I had, I'll take a look at your comments ASAP

johnpoth commented 4 years ago

Should be ok! Thanks !

astefanutti commented 4 years ago

Awesome! Thanks!