astefanutti / kubebox

⎈❏ Terminal and Web console for Kubernetes
http://astefanutti.github.io/kubebox
MIT License
2.15k stars 142 forks source link

let's use xterm v3 #8

Closed johnpoth closed 6 years ago

johnpoth commented 6 years ago

Added select + copy/paste functionality in remote shell

astefanutti commented 6 years ago

Looks great!

It seems selected text copy to clipboard only works in the browser. I wonder if we could use one of the following to integrate the Node version with the clipboard:

Besides, the shortcut to copy, CTRL+C, is already bound to exiting the program on Node version. I remember we want to change that, so that we can exit the exec terminal with CTRL+C, but then we need to check if there is a text selection when pressing CTRL+C, to decide whether to copy text or to exit the terminal.

Lastly, pasting doesn't seems to work when text is selected. Maybe we can listen for past event and deselect text.

Probably better to have that PR merged in master branch so that it's easier to continue working on it. But it's convenient to track the points above. Just let me know.

astefanutti commented 6 years ago

I've just merged the current state in master and create #10 so that we track remaining points.