search

astefanutti / metrics-aspectj

AspectJ integration for Dropwizard Metrics
Apache License 2.0
81 stars 39 forks source link

Clarify in README whether this plugin actually works with Spring AOP #8

Open erikthered opened 9 years ago

erikthered commented 9 years ago

There is a section in the README comparing Spring AOP vs AspectJ, but it doesn't indicate whether it's possible to use this plugin in conjunction with Spring AOP. Can the README be updated to state clearly whether this works with Spring AOP?

astefanutti commented 9 years ago

Thanks for the suggestion.

A reference can be added at the beginning of that section to point to the metrics-spring project which is supposed to be used in Spring based applications to integration Metrics and Spring AOP. I wonder whether that section is really bringing value here though.

Let me know what you think.

erikthered commented 9 years ago

Well, I feel like an idiot now. I didn't even see that there was a specific integration with Spring for DropWizard Metrics.

I think the Spring AOP vs AspectJ section might even be somewhat confusing in its current form. It might be worth making clear that this integration is for use only with AspectJ and that the metrics-spring project should be used with projects using Spring to do AOP.

astefanutti commented 9 years ago

No worries. Thanks for the feedback.

I'll rework that section to add pointers to metrics-spring, metrics-cdi, metrics-guice and make it clear in what context each one is to be used.