search

astei / krypton

A Fabric mod that optimizes the Minecraft networking stack and entity tracker.
GNU Lesser General Public License v3.0
367 stars 34 forks source link

"Connection lost" to localhost after extended periods of play #16

Closed Hoborific closed 3 years ago

Hoborific commented 3 years ago

I had Krypton installed on my local server and client and have faced an issue where I receive "connection lost" after an hour to so of gameplay, removing krypton has seemingly been the "solution"

The log for the client is empty at the time I get disconnected and there's no errors or warnings outside shaders printed during gameplay to indicate anything going wrong, the server itself still responds to remote and local connections fine just not my client which instantly cannot connect, there's no errors from a netty thread like I had expected for a networking issue for such an issue, not sure how to diagnose.

I am very willing to try a verbose printing/debug version of krypton if there is a way to do so if it helps find the incompatibility or issue that arises from having one or more of the mods I have installed present.

Please let me know, Thanks, Hobo.

and Krypton which was recently removed is version 0.1.1

xpopy commented 3 years ago

Same issue here, getting disconnected after just a minute from loading up a world. The old version 0.1.0 still works

astei commented 3 years ago

What mods do you run @xpopy?

xpopy commented 3 years ago

These are my mods

astei commented 3 years ago

The only mods in common on that list are Fabric API, LazyDFU (which can't cause this issue), Lithium, and Starlight. Time to go deeper.

astei commented 3 years ago

Please try build 46.

xpopy commented 3 years ago

Trying out the new build, I haven't gotten a disconnect yet but instead i've gotten desynced. Actions such as dropping items, changing gamemode doesn't actually do anything, and any blocks i place/destroy are not saved when i reload the world

K0-RR commented 3 years ago

@xpopy Sorry for off topic Where can I download sodium-extra? Also why are you using both smooth boot and lazydfu?

astei commented 3 years ago

Trying out the new build, I haven't gotten a disconnect yet but instead i've gotten desynced. Actions such as dropping items, changing gamemode doesn't actually do anything, and any blocks i place/destroy are not saved when i reload the world

I can't reproduce this on either a dedicated server or the integrated server. I am using a minimized list of mods, the ones in common on @Hoborific and your list of mods, and with Krypton build 46.

xpopy commented 3 years ago

@RDKRACZ https://github.com/FlashyReese/sodium-extra-fabric/ you can find a compiled version in the Github Actions, download the "build-artifacts" from the latest successfull build

I used smoothboot before i found lazydfu, just forgot to remove it

K0-RR commented 3 years ago

Thanks.

Hoborific commented 3 years ago

I haven't had a connection issue in four and a half hours with the build provided in this issue, will report back if it happens again.

Hoborific commented 3 years ago

it eventually happened, no message in either log in the last 40 minutes before the disconnect.

I did have a lot of errors such as: [02:19:02] [Server thread/WARN]: Mismatch in destroy block pos: class_2338{x=-411, y=68, z=648} class_2338{x=-485, y=71, z=644}

but I believe it to be unrelated and hasn't happened in console in over 4 minutes since the timeout

EcoBuilder13 commented 3 years ago

it eventually happened, no message in either log in the last 40 minutes before the disconnect.

I did have a lot of errors such as: [02:19:02] [Server thread/WARN]: Mismatch in destroy block pos: class_2338{x=-411, y=68, z=648} class_2338{x=-485, y=71, z=644}

but I believe it to be unrelated and hasn't happened in console in over 4 minutes since the timeout

To my knowledge that only happens when things like ghost blocks are created by client server de-sync.

astei commented 3 years ago

Let's try an older build. Does build 35 work?

Hoborific commented 3 years ago

no disconnect yet 4h45m of build35, a lot of client desync warnings using efficiency4 diamonds tools however I don't believe that to be related

astei commented 3 years ago

I've been unable to reproduce client desync issues with Krypton and a few other safe mods. So I honestly think desyncs are some other issue and probably not even Krypton-related.

If this holds up then the flush consolidation is at fault.

astei commented 3 years ago

Try build 47 build 48 - I've neutered flush consolidation significantly in this build.

astei commented 3 years ago

@Hoborific @xpopy sending a chaser to try build 48 of Krypton. If I don't get a response in a week I'm going to assume the issue has been fixed and will release a 0.1.2.

Hoborific commented 3 years ago

Sorry for the poor reply time, I have removed the mod from production however build 48 got a use time of at least five 5 hour runs, I can't confidently say it's fixed however the general reproduction had it crash within 5 hours with one exception over at least 6 runs before build 48.

I will reintroduce it into my live server to see if I can't get more man-hours behind it to reproduce.

I am quite happy with this outcome and will reopen if something arises.