astei / krypton

A Fabric mod that optimizes the Minecraft networking stack and entity tracker.
GNU Lesser General Public License v3.0
367 stars 34 forks source link

Slow connection #92

Open andreasdc opened 2 years ago

andreasdc commented 2 years ago

When you have multiple servers on you server list and you ping them and then you join the server, connecting will be slow. When you wait until the pings are finished, the connection will be fast. You need around 10/15 servers in your list for get the bug to appear. The pings are slow in general.

davidromrell commented 7 months ago

this is not a krypton bug but forge/fabric or vanilla

andreasdc commented 7 months ago

It is vanilla bug, but I didn't find bug that fixed that completely, unfortunately.

davidromrell commented 7 months ago

list mods here, I can probably help.

davidromrell commented 7 months ago

cause two likely possible problems 1. the mods 2. messing with ipconfig

andreasdc commented 7 months ago

I think switching to VPN causes that, no mod has timeout option for pinging and it often gets stuck, I think it would help a lot.

davidromrell commented 7 months ago

I have been surprised of some weird stuff mod interactions do.

davidromrell commented 7 months ago

I am almost positive now its your ipconfig, do a network reset.

andreasdc commented 7 months ago

It may be with dns changing, but still there's no timeout option in any mod, I think that would help the most, or some kind of clearing the pending pings.

davidromrell commented 7 months ago

This is the mod you want updated: https://modrinth.com/mod/fast-ip-ping/ The rest of them only apply to some cases.

davidromrell commented 7 months ago

I tried making a mod similar to what you stated, every time I tried it made performance in game worse.

andreasdc commented 7 months ago

Adding a timeout for ping made your ingame performance worse?

davidromrell commented 7 months ago

it was getting overridden, and so trying to get successful run made it worse.

davidromrell commented 7 months ago

the other factor is I was just trying to optimize in general, not just ping timeout. Although I probably would have ran into the same issues with ping timeout.

davidromrell commented 7 months ago

I am gonna try again later it was not as easy that I expected it to be.

andreasdc commented 7 months ago

I am gonna try again later it was not as easy that I expected it to be.

What are you trying? Maybe I can help. Can you send your discord username?

davidromrell commented 6 months ago

I temporarily paused on the project although here is the github: Ihttps://github.com/davidromrell/MyMod

andreasdc commented 6 months ago

Hmm I don't think it will work like that, but you can send your discord name maybe we will figure something out :)

davidromrell commented 6 months ago

so https://fabricmc.net/wiki/tutorial:setup is the BEST well documented tutorial for making a mod that does this. atm I am way to busy to help although, if you make code (even non-functioning if you state is such) I can likely get it to work given you copy reference or less preferable for security reasons path. Notes:
I recommend using IntelliJ . Problems you are trying to fix that would be helpful for you and anyone in your situation

  1. disable not remove: reverse DNS lookups, ok example of what is occurring in one case preferably I would solve more cases: templatefix.txt
  2. any network related code such as fabric-networking-api
  3. any io related code such as io.netty
  4. any http related code