search

aster94 / logic-analyzer

Logic Analyzer, for Arduino, AVR, ESP8266 and STM32 with a very nice working processing interface, you could run it also on any Android device.
GNU General Public License v3.0
351 stars 77 forks source link

Added the Mega version of processing and arduino code. #6

Closed sancho11 closed 5 years ago

sancho11 commented 5 years ago

New navigation features added too.

sancho11 commented 5 years ago

Siento el retraso, basicamente estaba muy ocupado con la universidad pero además olvide este proyecto (tengo más de un mes de estar en vacaciones, my bad). Ahora funciona bien. Feliz año nuevo!

aster94 commented 5 years ago

Hola sancho!

When I saw the code from hackster I didn't thought that there were so many changes, so for now I will mantain the pull request opened, I wouldn't like to risk to broke something. Anyway I think that the best way to handle many boards is not to have different processing scripts but just one with a few #define, like now, it handle the arduino UNO, stm32 and ESP8266 When I will have more time available I will use your code to add the needed defines in processing Also, since I wrote this when I started programming I think that there could be a few errors (especially about the style) so a review would be a good idea

muchas gracias por todos 🎉

sancho11 commented 5 years ago

Yes, I understand your point but the problem (or the reason because I do that) is that in the new code you can choose where you want to put every channel, you can put it one or several times in the order that you desire, or don't display it at all. You can do all this things in the pin assignment segment but since every board is different and you need to know how to make this for every one, so I didn't want overload the script with information (but perhaps there are a way), and finally I don't know how the disposition of the pins are for the STM32 or for the ESP8266. But shouldn't be a problem if I look Internet I suppose... Anyway my commit will not change any script it only add some scripts with code with my modifications. So if you have time you could try it!

Give me a day to merge the Arduino UNO and Arduino Mega in one script with definitions as you want.

sancho11 commented 5 years ago

Well my commit modify one script, the Arduino Mega code.

aster94 commented 5 years ago

... in the new code you can choose where you want to put every channel, you can put it one or several times in the order that you desire, or don't display it at all ...

This is a good idea! but unfortunatelly this applies only to arduino boards (and more precisely only on AVR) so for ESP8266 and STM32 it won't work (I may be wrong)

I think that if we want the correct pin names for all the boards unfortunatelly the redundancy is needed :( (I hate it also)

sancho11 commented 5 years ago

Hi, I made new modifications, now you can use the others boards in just one processing, to reach to that i had to make some changes in all arduino codes, because the new processing code needs receive the information in a little different way, but i havent a Arduino UNO or a STM32 or an ESP8266 so Im not totally secure if they are clean of errors, I really apreciate if you could check them. How i said a some months ago Im really proud of the improvements. I will paste here what I put in hackster that day, because is not only an Arduino Mega Integration, actually that is the less.

Hey Vizencio, I see your project and i love it, I think that almost all of your code was made with really good ideas and works well, you were really smart when using registers to collect the data in a very raw form, but also a efficient form. Since I haven't an Arduino Uno I was seeing your code and thinking make some modifications to use them with the Arduino Mega 2560 (I have that), and well now Im on vacations and I decided to get down to work, I made some modifications of your work, now it works with the Arduino Mega 2560 and supports up to 3 register of 8 bit for a total of 24 bits (but only can display up to 16bits). Second I made changes in the processing program to improve the performance in a low specs computer (At the begin my computer was unable of run fine your code xD). Third you can display up to 24 pins (16 channels simultaneously) and they can be chosen in the program easily even you can deactivate some channels if you want. Forth, i made a huge improvement in the navigation of the signals, now we have much more zoom scales and you will not miss you signal when you made a zoom change (like before), and the bigger chance that im proud of, is that now we have a navigation system so now you can pick a channel and with directional can move by change or "event" you can chose move for the events or one channel or all events, so the navigation is very easy!.

Finally I want to thank to you because with out your project I would not have been able to do this, even now I cant understand some parts of the arduino program (the parts related to the times). I hope that you take my intervention well. If you like the improvements, would be awesome if you share the new version as your (because it is yours in first place) as a new version, I think that could be very helpful to many people. Have a nice day. 😄

aster94 commented 5 years ago

How i said a some months ago Im really proud of the improvements. I will paste here what I put in hackster that day, because is not only an Arduino Mega Integration, actually that is the less.

You are right sancho, now I see that that there is way more 👍

I made a new branch where we can work for the corrections I will accept this pull request immediately and update some small fixes i did

i opened an issue where we can discuss #7 about the neeeded edits