asterics / AsTeRICS-Grid

Free and simple to use app for augmentative and alternative communication (AAC) with offline support, flexible input methods and media access
https://grid.asterics.eu/
GNU Affero General Public License v3.0
50 stars 17 forks source link

Proposing a simple means to cover various word forms from a button action #254

Closed jamjolu closed 3 months ago

jamjolu commented 1 year ago

I closed my own issue, #252 by accident (my own Github ignorance.) It is just as well as the suggestion by Klues led me to this proposal instead. I propose a button action that would permit users to toggle through various word forms for verbs, nouns, and adjective/adverbs. As Klues proposed a new tab in the button editing box called "grammar" into which one could record various verb conjugations and inflections, singular/plural noun forms, adjectival or adverbial alternatives etc.. I propose a more generic "word forms" tab that would be independent of grammar. Examples: be am is are being was were been box boxes hot hotter hottest

It could also function as a way to toggle through members of a related set: (positive, comparative, superlative) - good better best (sibling names) - John Mary Bob Mike

The Word Forms tab would would allow user's to record the set of word alternatives. The element action would index over the set of alternatives based on the last entry in the Collection element and replace the last element if an alternative exists. A button element with more than one word form could have a small + on it (similar to the small box for links) to denote the existence of word alternatives.

Please check out #252 for a more complete discussion. Thanks, jl

klues commented 5 months ago

Finally I think/hope we've reached a state which can be released to the main version. So please @jamjolu @msantos-87 @arasaac-dga read this final changes/new features and test them:

Additionally I did quite big changes to the code for the collection element (bar). Previously I've collected "text only" and "elements with images" separately, which results in quite complex and error-prone code. So I've changed it and now I'm collecting elements only in a single, unified way. However of course, this should be tested well, in order to make sure that I haven't broken something that was working before.

I've updated my test configuration, which you could also use: test-grammar_2024-02-07_09-55_asterics-grid-full-backup.zip

It contains:

If everything works fine and no errors are found, I would like to release this state and for fine-tuning or minor feature improvements, we should use new issues.

@arasaac-dga please also update the translations in crowdin.

ms-mialingvo commented 5 months ago

and 'I am' by clicking twice on 'to be'

So you're using I am as a word form of to be? I'm not sure it if this is the most flexible in the long term, and if forms of to be should really include the persons?!

There are a bunch languages that don't use separate pronouns so the equivalent of the English I am is one word (or one suffix). I originally was also using actually "I am" as a word form in languages like English or German, but yes, have noticed, that it's suboptimal.

Sending you an email in a moment.

klues commented 4 months ago

This is the finished textual documentation for the word form feature: https://github.com/asterics/AsTeRICS-Grid/blob/master/docs/documentation_user/10_word_forms.md

arasaac-dga commented 4 months ago

Checking if really our Grammar API wins over the Word Forms we have found one case in which that doesn't happen. As you can see in video attached (https://app.box.com/s/r2s2myp7p5luzbf5vmcdsrfe8c4ml4m0), when "Change word form in grid elements" is selected the verb is changed to "quiere" when you press in "él" and when you press PLAY the API grammar must change to "yo y él queremos comer" as made when you select other action like "Change in collection element" (see video https://app.box.com/s/r2s2myp7p5luzbf5vmcdsrfe8c4ml4m0). We have tried other communicators and the problem occurs too. So, please check it in order the API always win ;-)

klues commented 4 months ago

Your API still "wins" in this situation, however the result for yo y el quiere comer is the same using the API, see https://api.arasaac.org/api/phrases/flex/es/Yo%20y%20%C3%A9l%20quiere%20comer (you see that the API's result is used because the original is Yo and then it changes to yo)

In the second example yo y el quiero comer is sent to the API, which results in the correct sentence, see: https://api.arasaac.org/api/phrases/flex/es/Yo%20y%20%C3%A9l%20quiero%20comer

arasaac-dga commented 4 months ago

Yes, it's true. Thanks to this example we have located a little issue only with "want" verbs and only in some persons. With other verbs, fix the grammar correctly. So it's on our part. Thanks anyway for checking it.

klues commented 3 months ago

released with https://github.com/asterics/AsTeRICS-Grid/releases/tag/release-2024-03-20-08.17%2F%2B0100