Closed tchjohanna closed 1 month ago
Sorry, but it seems like you've simply removed most of the logic from printService.js
and there is no code for converting something to lower/uppercase which was the intent of #303. I don't know if you've pushed the wrong code, but the one in this PR doesn't work.
Also I'm wondering about this added code block:
async function addGridToPdf(doc, grid, options) {
// Logic for adding grid details to the PDF
// This part requires an implementation based on the specific needs of the project.
}
So who did the refactoring?! Some external person or any AI tool? I think for the first issues you should try to keep changes at a minimum and start with bigger refactorings only after you know the codebase quite well.
Also you've added some open SSH private key within this PR, which definitely shouldn't be the case. You should revoke this key and don't use it again, since it now was in public.
This branch contains the work we did together in our online meeting, where nearly everything from #303 is finished, but maybe the fontsize for uppercase has to be adjusted, since the labels are becoming too big: https://github.com/asterics/AsTeRICS-Grid/tree/issue%23303/pdf-lower-upper-case You can continue working on this branch directly within this repository, I've just sent you an invitation to add you as collaborator.
I've also created a PR https://github.com/asterics/AsTeRICS-Grid/pull/398 for this branch where you can see just minor changes for implementing #303 (not changing the whole file, like in this PR). Please continue with the other PR / the other branch, I'll close this PR.
Changes Proposed in this Pull Request
This pull request implements the conversion of PDF labels to handle both lower and upper case as discussed in Issue #303. The changes aim to improve the flexibility and usability of label formatting in PDF exports.
Major Changes
Motivation and Context
The need for case conversion was highlighted in discussions on Issue #303, where it was noted that users require the ability to format labels in PDFs according to specific case rules. This feature enhances the visual consistency and professionalism of the exported PDFs.
How Has This Been Tested?
Please review the changes and provide feedback or merge the pull request if everything is in order.