Closed klues closed 5 years ago
deinhofer
commented
5 years ago thanks for the refactoring, however unfortunately many things do not work as intended anymore (as far as I see from code), please refine.
Sorry for the heavy refactoring, but the code was really very buggy and bad style. So I refactored many parts. Let's reenable missing functionality together, it shouldn't be a big issue now.
klues
commented
5 years ago No problem, thats what a review is for ;) The "problem" is that we need this plugin today for our evaluation with the client, but I will simply use an earlier commit.
answering your remaining questions:
Are the properties propInitX and propInitY really necessary?
I would say they make sense for a solution where the tooltip location is not directly connected to the mouse position but static on a specific position of the screen.
Should the events elpNextTooltip and elpPrevTooltip also select the image and send out the imagefilename or not?
No, the filename should only be sent out, if a tooltip was selected. Maybe also see the documentation of the plugin included in this PR.
deinhofer
commented
5 years ago No problem, thats what a review is for ;) The "problem" is that we need this plugin today for our evaluation with the client, but I will simply use an earlier commit.
uups, sorry. I was thinking about that possibility, but than I thought you would use the other PR #281. Yes, please use an earlier commit:
git checkout e93094085032c0b5e524ee7d8c6adb18831312f0
should do it.
answering your remaining questions:
Are the properties propInitX and propInitY really necessary?
I would say they make sense for a solution where the tooltip location is not directly connected to the mouse position but static on a specific position of the screen.
Should the events elpNextTooltip and elpPrevTooltip also select the image and send out the imagefilename or not?
No, the filename should only be sent out, if a tooltip was selected. Maybe also see the documentation of the plugin included in this PR.
klues
commented
5 years ago @deinhofer: had to change the showTooltip() method and remove toggling of the window visibility because it breaks right and drag clicks of the mouse. Right-click-popups disappeared and drag-click was unintendetly released. see https://github.com/asterics/AsTeRICS/pull/283/commits/07daa3bbf526fc82c6aca22fc5eccdad3ab3a84a
klues
commented
5 years ago :star::star2::sparkles: :smiley: :sparkles::star2::star:
This is a new version of https://github.com/asterics/AsTeRICS/pull/281 I created this new branch in order to have a stable version in the other branch for the tests with our client (which unfortunately was'nt realized until yet).
This PR includes: 1) new plugin CrosshairCursorControl 2) new plugin AngularCursorControl 3) new plugin Tooltip -> tooltip functionality that at first was included in CrosshairCursorControl now as separate plugin in order to allow flexible usage 4) demo models for CrosshairCursorControl, all in
bin\ARE\models\useCaseDemos\mouseControl\crosshairCursorControl*.acs, including test models for keyboard and EMG singals. 5) demo models for AngularCursorControl, all inbin\ARE\models\useCaseDemos\mouseControl\angularCursorControl*.acs, including test models for keyboard and EMG singals. 6) new modelC:\data\src\AsTeRICS\bin\ARE\models\XFaceTrackerMouse_tooltips.acsthat integrates the Tooltip plugin into the cameramouse 7) Adaption of the Mouse plugin -> added output ports x/y and event listenermoveToLastStablefor interaction with Tooltip plugin 8) updated/added documentation for CrosshairCursorControl, AngularCursorControl, Tooltip and Mouse plugins@ChrisVeigl @deinhofer @benjaminaigner if you want, please review and/or test the demo models, so that we can merge.
@ point (6), cameramouse with tooltips: if you want to try this model, after starting: move your head/mouse around the screen some times and then continue normal, slower moving. this does some sort of calibration at the beginning. Afterwards nodding or shaking the head activates tooltips and nodding up/down or shaking left/right selects the next/previous tooltip.