search

asterics / AsTeRICS

The Assistive Technology Rapid Integration & Construction Set
http://www.asterics.eu
Other
57 stars 27 forks source link

added property "CIM.scan.active" instead of property "CIM.scan.at.start" #300

Closed klues closed 5 years ago

klues commented 5 years ago

New property "CIM.scan.at.start" in areProperties now allows to completely disable CIM-port scanning. This can be useful for models using plain serial communication where CIM-port scanning sometimes blocks the COM ports.

It also makes starting of ARE much faster, so I think it should be discussed if CIM.scan.at.start=false should be the default value since there are currently few models actually using the CIM modules.

deinhofer commented 5 years ago

New property "CIM.scan.at.start" in areProperties now allows to completely disable CIM-port scanning. This can be useful for models using plain serial communication where CIM-port scanning sometimes blocks the COM ports.

It also makes starting of ARE much faster, so I think it should be discussed if CIM.scan.at.start=false should be the default value since there are currently few models actually using the CIM modules.

The PR looks good, but will keep the default value = true, because it's better to provide a solution that always works although it is slower at startup. If you want to optimize the startup time you can do it by setting the value to false.

klues commented 5 years ago

👍