Klaus/issue#32/webacs model generation stringvalues - Githubissues

asterics / WebACS

HTML5/JS version of the AsTeRICS Configuration Suite

Apache License 2.0

3 stars 2 forks source link

Klaus/issue#32/webacs model generation stringvalues #33

Closed klues closed 5 years ago

klues commented 5 years ago

Fixes #32 by 795ecd36d6039f6fb24511d11cb579e399c16bd0 --> for combo-values of type STRING the "value" property of the option elements is set to the string instead of an integer ID.

additionally fixes problems with XML encoding that caused model deployments to fail if properties included characters like &, < or similar that are special XML characters.

klues commented 5 years ago

I tested this locally:

Model with AutostartEvent and ApplicationLauncher plugin opening a webpage in mode OPEN_URL -> works
opening URL containing an & -> works
changing captions in the cellboard of the autostart.acs model to a string containing & -> works
uploading, downloading, changing on WebACS and old ACS, "store model on ARE" in WebACS -> works

sabicalija commented 5 years ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

sabicalija commented 5 years ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

sabicalija commented 5 years ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

sabicalija commented 5 years ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

sabicalija commented 5 years ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

sabicalija commented 5 years ago

:tada: This issue has been resolved in version 1.0.0 :tada:

The release is available on GitHub release

sabicalija commented 5 years ago

:tada: This issue has been resolved in version 1.0.0 :tada:

The release is available on GitHub release

sabicalija commented 5 years ago

:tada: This issue has been resolved in version 1.0.0 :tada:

The release is available on GitHub release

sabicalija commented 5 years ago

:tada: This issue has been resolved in version 1.0.0 :tada:

The release is available on GitHub release