search

asterictnl-lvdw / M365SAT

Microsoft 365 Security Assessment Tool - A Easy-To-Use Microsoft 365 Security Assessment Tool
MIT License
38 stars 18 forks source link

Adjusting potentially unsafe code #16

Closed GraphiteCA closed 1 year ago

GraphiteCA commented 1 year ago

Removal of automatic self-elevation & self-updating, these features are flagged as unsafe by some security suites (eg Falcon), and halt operation of the script immediately. Updating will be better suited to be handled outside of the main script.

Thank you :)

asterictnl-lvdw commented 1 year ago

Hello @jpedlow ,

Thank you for your submission.

The self-elevation is only being done if the user actually agrees upon elevating. It does not elevate automatically for me, this mainly depends on your UAC settings. If you wish to not use the self-elevation then you can simply remove it for your own internal use.

I did not understand why you removed the dot sourcing from the update script? The actual updating will be done with PowerShell Gallery once it is submitted there from my side. And will be called from outside the main-script? But the psd1 file is not ready for it yet.

I will review this with my other companion to see if this is something that has to be pushed or that it has to be made a note for in the README.md instead of the code.

If there are any other issues, feel free to open an issue so I can check upon it.

Please close this pull request and create the pull request again for dev.

Thank you.

~LvdW