search

asteris-llc / converge

A powerful and easy-to-use configuration management system.
Apache License 2.0
250 stars 31 forks source link

Be sure that script is fully downloaded before run #633

Closed hauleth closed 6 years ago

hauleth commented 7 years ago

This also removes some smells there and here like needless two step checks for command status. However there is still much room to for improvements.

hauleth commented 7 years ago

As there is a lot of whitespace changes it is the best to view it with whitespace changes ignored (you can add ?w=1 at the end of URL to achieve that).

rebeccaskinner commented 7 years ago

Thanks for the PR; I'll get that merged soon. We have some wercker issues that make it difficult to merge directly from fork forked repos, but it should go in this week.

hauleth commented 7 years ago

@rebeccaskinner the point is that this PR doesn't touch any of the Go files and ./install-converge.sh isn't covered in test suite from what I seen.