search

asterisk / asterisk

The official Asterisk Project repository.
https://www.asterisk.org
Other
2k stars 929 forks source link

sig_analog: Add Call Waiting Deluxe support. #272

Open InterLinked1 opened 9 months ago

InterLinked1 commented 9 months ago

Adds support for Call Waiting Deluxe options to enhance the current call waiting feature.

As part of this change, a mechanism is also added that allows a channel driver to queue an audio file for Dial() to play, which is necessary for the announcement function.

ASTERISK-30373 #close

Imported from Gerrit: https://gerrit.asterisk.org/c/asterisk/+/19748

Resolves: #271

asterisk-org-access-app[bot] commented 9 months ago

REMINDER: If this PR applies to other branches, please add a comment with the appropriate "cherry-pick-to" headers as per the Create a Pull Request process.

If you don't want it cherry-picked, please add a comment with cherry-pick-to: none so we don't keep asking.

If, after adding "cherry-pick-to" comments, you change your mind, please edit the comment to DELETE the header lines and add cherry-pick-to: none.

The currently active branches are now 18, 20, 21 and master.

InterLinked1 commented 9 months ago

cherry-pick-to: 18 cherry-pick-to: 20 cherry-pick-to: 21

InterLinked1 commented 7 months ago

@asteriskteam Would someone mind giving this review in particular a look soon, if they have time? Don't want to nag, but because of the monolithic architecture of chan_dahdi, it's very difficult to do concurrent development for chan_dahdi so things have to be serialized. Thanks!

jcolp commented 7 months ago

@asteriskteam Would someone mind giving this review in particular a look soon, if they have time? Don't want to nag, but because of the monolithic architecture of chan_dahdi, it's very difficult to do concurrent development for chan_dahdi so things have to be serialized. Thanks!

The reality is that community members have no interest in reviewing these kind of changes, and personally I put such changes at the bottom of my todo list. You can continue to do development of chan_dahdi for your needs/interests/purposes, but the review times here are likely to continue to be a long time.

InterLinked1 commented 2 months ago

@jcolp Sorry to prod again, but would you mind taking another look at this when you have time? I realize there are a lot of patches sitting, but since this one is adding control frames and such, it would be really helpful if this could move along to avoid ABI headaches - thanks!

asteriskteam commented 1 month ago

This PR has been marked stale because it has been in "Changes Requested" or "submitter-action-required" state for 28 days or more. Please make the requested changes within 14 days or the PR will be closed.

asteriskteam commented 1 month ago

This PR has been closed because it has been in "Changes Requested" or "submitter-action-required" state for more than 42 days.

asteriskteam commented 3 days ago

This PR has been marked stale because it has been in "Changes Requested" or "submitter-action-required" state for 28 days or more. Please make the requested changes within 14 days or the PR will be closed.