search

asterisk / asterisk

The official Asterisk Project repository.
https://www.asterisk.org
Other
1.99k stars 929 forks source link

chan_pjsip: Add the same details as PJSIPShowContacts to the CLI via 'pjsip show contact' #644

Open intellasoft opened 2 months ago

intellasoft commented 2 months ago

CLI 'pjsip show contact' does not show enough information. One must telnet to AMI or write a script to ask Asterisk for example what the User-Agent is on a Contact This feature adds the same details as PJSIPShowContacts to the CLI

kobaz commented 2 months ago

Fixes #643

github-actions[bot] commented 2 months ago

REMINDER: If this PR applies to other branches, please add a comment with the appropriate "cherry-pick-to" headers as per the Create a Pull Request process.

If you don't want it cherry-picked, please add a comment with cherry-pick-to: none so we don't keep asking.

If, after adding "cherry-pick-to" comments, you change your mind, please edit the comment to DELETE the header lines and add cherry-pick-to: none.

The currently active branches are now 18, 20, 21 and master.

kobaz commented 2 months ago

cherry-pick-to: none

seanbright commented 2 months ago

That is a lot of code to change to pass a boolean down to a single callback. There is no better way?

If not, all of the header documentation needs to be updated to include the new flags argument.

seanbright commented 2 months ago

Could you use one of the existing fields in struct ast_sip_cli_context? Or add a new one?

kobaz commented 2 months ago

Could you use one of the existing fields in struct ast_sip_cli_context? Or add a new one?

Good call. I'll look into that.

asteriskteam commented 1 month ago

This PR has been marked stale because it has been in "Changes Requested" or "submitter-action-required" state for 28 days or more. Please make the requested changes within 14 days or the PR will be closed.

asteriskteam commented 1 month ago

This PR has been closed because it has been in "Changes Requested" or "submitter-action-required" state for more than 42 days.

intellasoft commented 1 month ago

What's the process to re-open?

jcolp commented 1 month ago

I clicked the reopen button.

intellasoft commented 1 month ago

Yaaaay, thanks.

I don't think I have access to a reopen. I was looking for one.

Updates coming asap!

asteriskteam commented 3 days ago

This PR has been marked stale because it has been in "Changes Requested" or "submitter-action-required" state for 28 days or more. Please make the requested changes within 14 days or the PR will be closed.