search

asterisk / asterisk

The official Asterisk Project repository.
https://www.asterisk.org
Other
1.97k stars 924 forks source link

Initial RTP inactivity check must consider the rtp_timeout setting. #706

Closed henlil closed 2 weeks ago

henlil commented 1 month ago

First rtp activity check was performed after 500ms regardless of the rtp_timeout setting. Having a call in ringing state for more than rtp_timeout and the first rtp package is received more than 500ms after sdp negotiation and before the rtp_timeout, erronously caused the call to be hungup. Changed to perform the first rtp inactivity check after the timeout setting preventing calls to be disconnected before the rtp_timeout has elapsed since sdp negotiation.

Fixes #710

sangoma-oss-cla[bot] commented 1 month ago

CLA assistant check
All committers have signed the CLA.

henlil commented 1 month ago

cherry-pick-to: 18 cherry-pick-to: 20 cherry-pick-to: 21

gtjoseph commented 2 weeks ago

@henlil Just FYI for next time... The PR description doesn't get automatically updated when you update the commit message and the "Fixes" line has to appear in the PR description or the related issue won't be automatically closed. I fixed it for you.

github-actions[bot] commented 2 weeks ago

Successfully merged to branch master and cherry-picked to ["18","20","21"]