asterisk / asterisk

The official Asterisk Project repository.
https://www.asterisk.org
Other
1.97k stars 924 forks source link

sorcery.c: Fixed crash error when executing "module reload" with sorcery cache registration and res_prometeus #709

Closed codeworld0 closed 3 weeks ago

codeworld0 commented 1 month ago

sorcery.c: Fixed crash error when executing "module reload" with sorcery cache registration and res_prometeus

Fixed crash error when cli "module reload". The error appears when compiling with res_prometheus and using the sorcery memory cache for registrations

sangoma-oss-cla[bot] commented 1 month ago

CLA assistant check
All committers have signed the CLA.

codeworld0 commented 1 month ago

Corrected. Check, please

jcolp commented 1 month ago

You only updated the PR title, the commit message itself was not updated. It should also be "crash" not "crush", and ensure that the line length does not exceed 72.

Instructions for updating a review is here:

https://docs.asterisk.org/Development/Policies-and-Procedures/Code-Contribution/#address-review-comments-and-test-failures

codeworld0 commented 1 month ago

Corrected again. Check, please

github-actions[bot] commented 3 weeks ago

REMINDER: If this PR applies to other branches, please add a comment with the appropriate "cherry-pick-to" headers as per the Create a Pull Request process.

If you don't want it cherry-picked, please add a comment with cherry-pick-to: none so we don't keep asking.

If, after adding "cherry-pick-to" comments, you change your mind, please edit the comment to DELETE the header lines and add cherry-pick-to: none.

The currently active branches are now 18, 20, 21 and master.

codeworld0 commented 3 weeks ago

cherry-pick-to: 18 cherry-pick-to: 20 cherry-pick-to: 21

github-actions[bot] commented 3 weeks ago

Successfully merged to branch master and cherry-picked to ["18","20","21"]