search

asterisk / documentation

The Asterisk Documentation Project.
https://docs.asterisk.org/
Other
26 stars 22 forks source link

docs: rewrite pattern matching documentation #58

Open arthursimas1 opened 4 months ago

arthursimas1 commented 4 months ago

This PR proposes a rewrite in the pattern matching documentation for better clarity and organization.

I first started to fix the final section about Matching on Caller ID, but then I realized that the whole document could be further improved.

I'm willing to change it based on your suggestions.

I need some clarification:

What is the other character with special meaning? Notice the final and ...

If I write it as "it will look for that next priority in a less specific pattern match", does it still represents the correct behaviour? I thought it's clearer.

Only ! is used for overlap dialing or . can also be used? Is this the difference that the old text was talking about?

I couldn't find nothing regarding overlap dialing on the Asterisk docs. Does this page exist? We could link it here. If it's missing, we can write something in that matter (example)

Resolves: https://github.com/asterisk/documentation/issues/56

arthursimas1 commented 4 months ago

@jcolp @gtjoseph

gtjoseph commented 4 months ago

@arthursimas1 Thanks for the contribution! It's a lot so it'll probably take us a few days to get through it.

arthursimas1 commented 4 months ago

Yeah, I perfectly understand. Take your time! (just don't forget about it 😂)

sangoma-oss-cla[bot] commented 4 months ago

CLA assistant check
All committers have signed the CLA.

arthursimas1 commented 4 months ago

@jms72 I really appreciate the time you spent to review this. Thank you!

gtjoseph commented 3 months ago

I'm closing and re-opening this PR so it triggers the new workflow job that does a temporary build.

arthursimas1 commented 3 months ago

Thanks all for the review! I'll take a look into it in the following days (the PR isn't abandoned!)