search

asterisk / node-ari-client

Node.js client for ARI. This library is best effort with limited support.
Other
250 stars 98 forks source link

Add ping event and add emit method for pong #105

Closed jp1987 closed 6 years ago

jp1987 commented 6 years ago

To avoid half open socket connections, for instance when connecting to Asterisk over VPN, add a client.ping() method and emit the pong event when received.

Fixes #104

danjenkins commented 6 years ago

I see no reason not to add this in to the project.

If @samuelg / @chadxz have nothing against it, I'll merge it and cut a new npm release.

samuelg commented 6 years ago

The README is generated from https://github.com/asterisk/node-ari-client/tree/master/dev. The changes here will get wiped the next time we generated from the ARI swagger definition. Otherwise looks good to me.

chadxz commented 6 years ago

If you could remove the README changes that would be great. If you want to update the mustache template to mention this method/event that would be nice, but not a big deal. @danjenkins :shipit: whenever

jp1987 commented 6 years ago

Thanks guys. I've removed the changes from the README.