search

asterisk / node-ari-client

Node.js client for ARI. This library is best effort with limited support.
Other
253 stars 99 forks source link

Update package.json #107

Closed tm1000 closed 6 years ago

tm1000 commented 6 years ago

Fixes #106 however it already had a ^ so newer installs would have been fine. Its the older ones that have the issue.

chadxz commented 6 years ago

As you mentioned this is pretty much a no-op, even for existing installs, because no matter if we merge this or not, existing installs would need to update their own dependencies to get the fix pulled in.

I don't feel strongly either way about it.

tm1000 commented 6 years ago

Agree. Dan and I talked about it as well. You can decline it’s fine :)

Get Outlook for iOShttps://aka.ms/o0ukef

From: Chad McElligott notifications@github.com Sent: Wednesday, May 30, 2018 10:49:59 AM To: asterisk/node-ari-client Cc: Andrew Nagy; Author Subject: Re: [asterisk/node-ari-client] Update package.json (#107)

As you mentioned this is pretty much a no-op, even for existing installs, because no matter if we merge this or not, existing installs would need to update their own dependencies to get the fix pulled in.

I don't feel strongly either way about it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/asterisk/node-ari-client/pull/107#issuecomment-393256124, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAicIJr7u9ztPER70_THNO8X_Fq1ngeSks5t3tvHgaJpZM4UTnxd.