search

asterisk / node-ari-client

Node.js client for ARI. This library is best effort with limited support.
Other
257 stars 102 forks source link

No formats when creating a channel #117

Closed DanieleSIS closed 5 years ago

DanieleSIS commented 6 years ago

Hello I cannot create or originate a channel with the paramater "formats". This parameter is used into Asterisk 14 (we use this version). Without it, we cannot create a channel that can use *.ulaw files. Is it possible to add this parameter (formats) to the POST request that create the channel ?

This is the call we do manually with a RestClient. http://192.168.181.102:8088/ari/channels/create?endpoint=Local/110&app=TestAppelant&formats=ulaw

Thanks Daniele

samuelg commented 6 years ago

It's entirely possible yes. I'll take a look as soon as I can carve out some free time.

DanieleSIS commented 6 years ago

Ok thanks a lot.

DanieleSIS commented 6 years ago

Hi, could you take a look for us? Thanks a lot

samuelg commented 6 years ago

I have a PR up for the fix. I'll look at merging it as soon as I have some free time.

On Fri, Sep 21, 2018 at 9:25 AM DanieleSIS notifications@github.com wrote:

Hi, could you take a look for us? Thanks a lot

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/asterisk/node-ari-client/issues/117#issuecomment-423549945, or mute the thread https://github.com/notifications/unsubscribe-auth/AABVylT57NRASVJ29YDuSrjeeShY7KzHks5udPb1gaJpZM4Wcndm .

-- Samuel Fortier Galarneau

DanieleSIS commented 6 years ago

Hi, we would like to know if it's ok or not yet. Thanks a lot.

samuelg commented 5 years ago

Should be good to go as of version 1.3.0.