search

asterisk / node-ari-client

Node.js client for ARI. This library is best effort with limited support.
Other
259 stars 102 forks source link

PlaybackFinished does not differentiate between file playback complete or there is an error while playing #139

Open praiseable opened 4 years ago

praiseable commented 4 years ago

"Unfortunately, playbackControl.state isn't different from the one that a successful play has. My work-around is to measure the time period between PlaybackStarted and PlaybackFinished events. I've created an issue in the Asterisk jira, https://issues.asterisk.org/jira/browse/ASTERISK-26661."

I have done some changes at asterisk side code and now i am getting proper response. I can differentiate between actual file played successful and complete and when was unable to play successful then i got error response on PlaybackFinished. I want to share my contribution with asterisk code i am finding a way to do that

pbpraveen1988 commented 3 years ago

Hi @praiseable can you please post your code, same issue i am also facing , that would be really helpful.

Thanks

praiseable commented 3 years ago

Share your mailing address

On Sat, 6 Feb 2021, 19:04 Praveen Kumar, notifications@github.com wrote:

Hi @praiseable https://github.com/praiseable can you please post your code, same issue i am also facing , that would be really helpful.

Thanks

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/asterisk/node-ari-client/issues/139#issuecomment-774482614, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEO5LYXLANUXAM5NPXG6FETS5VD77ANCNFSM4MK7X2LA .

pbpraveen1988 commented 3 years ago

pbpraveen1988@gmail.com, thanks for the help.

Share your mailing address … On Sat, 6 Feb 2021, 19:04 Praveen Kumar, @.***> wrote: Hi @praiseable https://github.com/praiseable can you please post your code, same issue i am also facing , that would be really helpful. Thanks — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#139 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEO5LYXLANUXAM5NPXG6FETS5VD77ANCNFSM4MK7X2LA .

praiseable commented 3 years ago

sorry for late reply. I have implemented changes in asterisk code. You need to replace the file and re-compile the code in asterisk.

On Sat, Feb 6, 2021 at 7:49 PM Praveen Kumar notifications@github.com wrote:

pbpraveen1988@gmail.com, thanks for the help.

Share your mailing address … <#m-8135430110373359262> On Sat, 6 Feb 2021, 19:04 Praveen Kumar, @.***> wrote: Hi @praiseable https://github.com/praiseable https://github.com/praiseable can you please post your code, same issue i am also facing , that would be really helpful. Thanks — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#139 (comment) https://github.com/asterisk/node-ari-client/issues/139#issuecomment-774482614>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEO5LYXLANUXAM5NPXG6FETS5VD77ANCNFSM4MK7X2LA .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/asterisk/node-ari-client/issues/139#issuecomment-774488335, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEO5LYU242EWH2ACXXQBIKLS5VJFZANCNFSM4MK7X2LA .

-- ALI@ALI

praiseable commented 3 years ago

is this be feasible for you or not ??

On Mon, Feb 8, 2021 at 2:13 PM praiseable5 praiseable5@gmail.com wrote:

sorry for late reply. I have implemented changes in asterisk code. You need to replace the file and re-compile the code in asterisk.

On Sat, Feb 6, 2021 at 7:49 PM Praveen Kumar notifications@github.com wrote:

pbpraveen1988@gmail.com, thanks for the help.

Share your mailing address … <#m_8995203822186391844m-8135430110373359262_> On Sat, 6 Feb 2021, 19:04 Praveen Kumar, @.***> wrote: Hi @praiseable https://github.com/praiseable https://github.com/praiseable can you please post your code, same issue i am also facing , that would be really helpful. Thanks — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#139 (comment) https://github.com/asterisk/node-ari-client/issues/139#issuecomment-774482614>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEO5LYXLANUXAM5NPXG6FETS5VD77ANCNFSM4MK7X2LA .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/asterisk/node-ari-client/issues/139#issuecomment-774488335, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEO5LYU242EWH2ACXXQBIKLS5VJFZANCNFSM4MK7X2LA .

-- ALI@ALI

-- ALI@ALI