search

asterisk / node-ari-client

Node.js client for ARI. This library is best effort with limited support.
Other
250 stars 98 forks source link

Fixes #62 in a simpler way #64

Closed mpotra closed 7 years ago

mpotra commented 7 years ago

Fixes #62 and replaces PR #63

chadxz commented 7 years ago

@samuelg @danjenkins care to review?

mpotra commented 7 years ago

@chadxz On a second look, indeed it makes more sense to leave that bit in place, just in case binary will ever get added to the known types. Plus, it makes for a smaller and cleaner commit. I've just updated with a squashed commit.

chadxz commented 7 years ago

looks great, thanks!

chadxz commented 7 years ago

Going to wait and make sure @samuelg doesn't have any thoughts to add, then will merge.

danjenkins commented 7 years ago

@samuelg :D

samuelg commented 7 years ago

Looks good to me!

chadxz commented 7 years ago

released to npm as v1.1.0