search

asterisk / node-ari-client

Node.js client for ARI. This library is best effort with limited support.
Other
250 stars 98 forks source link

Initial connection failure : update swagger-client ? #73

Closed jaunis closed 7 years ago

jaunis commented 7 years ago

Currently, if Asterisk is not started when ari-client tries to open a connection, the error callback is not fired as we would expect to.

It seems to be a bug in swagger-client, which is apparently fixed in the latest version (2.1.26 this day). I cannot figure out precisely which version fixed this, but my own tests suggest it is actually working in the current one.

So, is it possible to update the swagger-client version to 2.1.26 ?

danjenkins commented 7 years ago

Unfortunately we can't update to the latest swagger client and we are running the latest version of swagger-client that works with Asterisk today. This is because of the version of Swagger that Asterisk uses. There have been quite a few discussions now about trying to move Asterisk forward to utsing the latest version of Swagger (which is now the Open API Specification) - but this just hasn't happened yet. this is still a bug, but if we want to fix it with current swagger version, it'll mean forking the swagger client we're using today

jaunis commented 7 years ago

I see. I will live with it for the moment and close the issue. Thank you for your quick answer.

ghost commented 3 years ago

Hi @danjenkins - do you have any news on whether there were still plans to update this to the current version of Swagger?

Or is there an alternative library? I've looked at forks and alternatives, but nothing fits.

Don't want to start down the ARI path if the library is deprecated.

Thanks!

Unfortunately we can't update to the latest swagger client and we are running the latest version of swagger-client that works with Asterisk today. This is because of the version of Swagger that Asterisk uses. There have been quite a few discussions now about trying to move Asterisk forward to utsing the latest version of Swagger (which is now the Open API Specification) - but this just hasn't happened yet. this is still a bug, but if we want to fix it with current swagger version, it'll mean forking the swagger client we're using today

danjenkins commented 3 years ago

ARI isnt being deprecated, and theres nothing wrong with using the old version of the swagger module as such.... but I agree it all needs updated but requires that change to happen in the core of asterisk

ghost commented 3 years ago

Hi @danjenkins - sorry, I figured that out after a while and I thought I'd delete my post above, but obviously not! ARI is great - it's just where the warning was coming from that confused me. Got my head round it now -thanks!