asterisk / pjproject-archive

Asterisk fork of PJSIP NO PULL REQUESTS OR ISSUES!!!
GNU General Public License v2.0
69 stars 42 forks source link

[Python] Class objects are using obsolete class design #23

Closed mo-g closed 6 years ago

mo-g commented 6 years ago

Stylistic/futureproofing issue:

The classes in pjproject are designed as 'Old Style' classes as opposed to 'new style'. This means that code using pjproject as a library is forced to use out-of-date methods when importing pjsua. This is also a blocker for Python3 support as Python3 exclusively uses new style classes.

I thought it appropriate to flag this as a discussion point instead of just assuming myself correct and throwing up a pull request. Thoughts?

mo-g commented 6 years ago

When you assume the first github repo you find is the canonical source of a codebase without checking.

Still interested in anyone's opinion, but I assume this is one of those things that would be best targeted at the upstream pjsip development.