asterisk / starpy

Python twisted library for AMI and FastAGI
Other
95 stars 61 forks source link

AMI Originate - Update/fix multiple variable support #32

Closed exvito closed 9 years ago

exvito commented 9 years ago

Changing AMI Originate to send multiple variables as multiple entries of the "Variable" key, as per documentation of Asterisk 1.4 onwards.

Now sends:

> Action: Originate
> Variable: VAR_A=va
> Variable: VAR_B=vb
> ...

Instead of the single key with comma-separated variables:

> Action: Originate
> Variable: VAR_A=va,VAR_B=vb
> ...

Motives:

PS: Made possible based on the work from PR #24 which allows sending AMI Actions with repeated "keys".

Final notes:

Thanks for your review and feedback.

exvito commented 9 years ago

Owners,

Any feedback?

Thanks again.

russellb commented 9 years ago

Looks good, thanks!

exvito commented 9 years ago

Great. Thanks.