search

asteroid-team / asteroid-filterbanks

Asteroid's filterbanks :rocket:
https://asteroid-team.github.io/
MIT License
80 stars 20 forks source link

With center=True in Encoder and Decoder #3

Closed mpariente closed 3 years ago

mpariente commented 3 years ago

Trying to add center=True in Encoder and Decoder but I'm not fully satisfied for the Decoder.

For the Encoder, I think it's fine. It just add two frames, that will be removed afterwards. For the Decoder, I'll comment inline.

Note: the base of the PR is torch_compat

mpariente commented 3 years ago

Another solution would be to enable each filterbank to overwrite the encode/decode. Don't know if this is good software practice.. I'm might be ok with the current solution in #2. Feedback appreciated.

mpariente commented 3 years ago

I'm closing this because most people agree. The center in the encoder and decoder is not useful.