Closed mpariente closed 3 years ago
Another solution would be to enable each filterbank to overwrite the encode/decode. Don't know if this is good software practice.. I'm might be ok with the current solution in #2. Feedback appreciated.
I'm closing this because most people agree. The center in the encoder and decoder is not useful.
Trying to add
center=True
inEncoder
andDecoder
but I'm not fully satisfied for theDecoder
.For the
Encoder
, I think it's fine. It just add two frames, that will be removed afterwards. For theDecoder
, I'll comment inline.Note: the base of the PR is
torch_compat