Closed faroit closed 3 years ago
@mpariente torch.stft
doesn't support 3D, asteroid
doesn't support 2D inputs, any idea for a less hacky unit test?
Did torch.stft always behave like this?
Actually, we want to behave like nn.Conv1d, not like torch.stft, so it doesn't matter that the shapes are not the same.
Actually, we want to behave like nn.Conv1d, not like torch.stft, so it doesn't matter that the shapes are not the same.
maybe then we add the channel-> batch wrapping for the unit tests of torch.stft
so that they give the same output?
@mpariente maybe you are quicker to carry out the unit-test changes? In that case I can just revert 18068e2 so that we just merge the fix followed by unit test changes by you later
I'd rather have the unit test before merging and sorry but I don't have time for it now.
related: @jonashaag do you know of any news regarding nd-support for torch.stft and torch.istft?
I think you were reporting this first on https://github.com/pytorch/pytorch/issues/42813
@mpariente ready for review
@faroit haven't read this issue and I'm not following the PyTorch one. Feel free to follow up there with whatever you think is appropriate. I can't reopen that ticket
@mpariente 👍 would you be able to push a new release soon?
Addresses #7