search

asteroid-team / asteroid

The PyTorch-based audio source separation toolkit for researchers
https://asteroid-team.github.io/
MIT License
2.27k stars 423 forks source link

Next release : 0.4.0 #303

Closed mpariente closed 3 years ago

mpariente commented 4 years ago

If we can merge #298 #302 and #257, it's also cool, but not required. After that, we'll need to upgrade pytorch-lightning.

popcornell commented 4 years ago

After this release we can break things and not be tied to be retro-compatible ?

mpariente commented 4 years ago

0.4.0 will break BC in few ways:

Those are very small BC break IMO.

After this release we can break things and not be tied to be retro-compatible ?

No, we'll try to be backwards compatible (BC) the most we can, always. If we want to break BC completely, it'll be on asteroid 1.0.0 (exciting!).

Are there things that would require to break BC currently? Is this related to your comments in #306 ?

popcornell commented 4 years ago

Yeah I was thinking exactly that. The refactoring of masknn.

mpariente commented 3 years ago

Should we remove DCCRN fix and compatibility tests from the 0.4.0 release? I'd like to release quite soon so that we can work on 0.4.1 to upgrade lightning.

I think both of these are assigned to you @jonashaag :wink:

jonashaag commented 3 years ago

I can put a DCCRN PR today, it only has be cleaned up. I don't know much about jitability though so not sure how long that will take. I can also work on #279 today

mpariente commented 3 years ago

Great thanks !

script doesn't allow function definition, so on_reim won't be scriptable, but probably traceable, but not even sure. I can do that part if you want.

mpariente commented 3 years ago

We're finally ready for 0.4.0 release, thanks a lot for your dedicated work !

mpariente commented 3 years ago

The docs has several empty sessions, I need to fix that.

mpariente commented 3 years ago

Released ! :rocket: