Pytorch-optimizer dropped RAdam optimizer

asteroid-team / asteroid

The PyTorch-based audio source separation toolkit for researchers

https://asteroid-team.github.io/

MIT License

2.22k stars 422 forks source link

Closed ben-freist closed 2 years ago

ben-freist commented 2 years ago

In https://github.com/jettify/pytorch-optimizer/pull/377 pytorch-optimizer was updated and no longer includes the RAdam optimizer but asteroid/engine/optimizers.py still tries to import it.

At the moment I've added pytorch-optimizers < 0.2.0 to my requirements.txt to work around it.

My asteroid version is 0.5.0dev, but it looks like the situation is the same on master.

mpariente commented 2 years ago

Thanks for the issue. Could you make a PR adding this change to the requirement file please? That would be great, thanks !

ben-freist commented 2 years ago

No problem, I just created the MR.

mpariente commented 2 years ago

Closed by #568