In all of the eval.py scripts in egs there are only calls to torch.no_grad().__enter__() and I believe there should be also a model.eval() call. I know that for the most cases there will be no difference, but for example in egs/whamr/TasNet/local/conf.yml there is dropout=0.3, so it can matter, and the more important thing is that, it can lead to new bugs and strange behavior when eval.py is reused with new models (I had this problem).
In all of the
eval.py
scripts inegs
there are only calls totorch.no_grad().__enter__()
and I believe there should be also amodel.eval()
call. I know that for the most cases there will be no difference, but for example inegs/whamr/TasNet/local/conf.yml
there isdropout=0.3
, so it can matter, and the more important thing is that, it can lead to new bugs and strange behavior wheneval.py
is reused with new models (I had this problem).