search

asteroid-team / asteroid

The PyTorch-based audio source separation toolkit for researchers
https://asteroid-team.github.io/
MIT License
2.21k stars 419 forks source link

Wrong release for DNS Challenge 2020 #656

Open jonpodtu opened 1 year ago

jonpodtu commented 1 year ago

🐛 Bug

Regard using the DNS-Challenge baseline, there are issues when using the newest version of the DNS Challenge repo, where the main problems occur when evaluating models, as the testdata has been removed from the repo newest release of the DNS Challenge repo.

I suggest that in line 9 in asteroid/blob/master/egs/dns_challenge/baseline/local/download_data.sh is changed from git clone https://github.com/microsoft/DNS-Challenge to git clone -b interspeech2020/master https://github.com/microsoft/DNS-Challenge so it clones the last stable release of the DNS Challenge 2020 repo.

mpariente commented 1 year ago

Sounds like the good solution, can you submit a PR please ?

Rodolfo-S commented 3 months ago

Adding to this, should the name of the recipe directory be changed to reflect which version of the DNS dataset it's using (i.e. "dns_challenge_INTERSPEECH_2020" rather than "dns_challege")? This would make it so that other versions of the DNS Challenge dataset could be potentially added as their own recipes.

mpariente commented 3 months ago

Makes sense ! Please make PRs