Closed LeonieBorne closed 1 year ago
This is perfect, thank you ! ✨
It's in the commits, but I rewrite it here for more visibility : pytorch-lightning
was limited to 1.7.7 because the Callback.on_epoch_start
hook was removed in v1.8.
Regarding your questions :
upstream
, and create a new branch from there. But doing it how you did is fine, because we squash the commits when merging, so the git history is not polluted.
Hi @mpariente 🐿️
I tried to fix the continuous integration before doing a new release (as mentioned in #664). It should work 🤞 But I have a couple of questions:
master
intoci_fix
branch. Should I have forked the repo a second time before doing my new commits? Or rebase my development branch as proposed here?scipy.signal.get_window(window="hanning")
is not supported in newer version of scipy and is replaced bywindow="hann"
(check documentation v0.11.0 vs v1.11.1). I didn't succeed to install a version ofscipy
which works withwindow="hanning"
and is compatible with the others libraries installed in the requirements. So instead, I replacedhanning
byhann
in the arguments and changed the requirements toscipy>=1.10.1
(which works on my computer). I feel like it is not the best solution aswindow="hanning"
was working before, should I change this fix?Thanks!