search

asteroid-team / torch-audiomentations

Fast audio data augmentation in PyTorch. Inspired by audiomentations. Useful for deep learning.
MIT License
969 stars 88 forks source link

Link to Pyroppl License in fft and convolve code #78

Closed mpariente closed 3 years ago

mpariente commented 3 years ago

It would make more sense to have a header saying that it's copied or adapted from there. See the original implementation.

iver56 commented 3 years ago

Pyro and its license is already mentioned in each function that is copied from there, e.g. https://github.com/asteroid-team/torch-audiomentations/blob/2aa6bfa31acbc9e7787076d380685b5b507608c7/torch_audiomentations/utils/convolution.py#L46

What more is needed? Would you like to make a pull request?

mpariente commented 3 years ago

I expected a header in the file and I didn't spend enough time checking the docstring, very sorry about that.