search

astheeggeggs / lshmm

code to run Li and Stephens
MIT License
3 stars 3 forks source link

Missingness #16

Closed astheeggeggs closed 1 year ago

astheeggeggs commented 1 year ago

Updated lshmm to include missing data in the diploid case.

jeromekelleher commented 1 year ago

Would you like a review here @astheeggeggs?

astheeggeggs commented 1 year ago

Would you like a review here @astheeggeggs?

That'd be great, yep!

astheeggeggs commented 1 year ago

Yeah, fair point. I'll leave it for now, but in the next version, I think I'll remove all but the variants x samples with and without normalisation (and all the testing related to that).

On Fri, Sep 23, 2022 at 11:47 AM Jerome Kelleher @.***> wrote:

@.**** approved this pull request.

LGTM

I wonder if there's much point in carrying around all the different variants of the algorithms at this point though.

— Reply to this email directly, view it on GitHub https://github.com/astheeggeggs/lshmm/pull/16#pullrequestreview-1118254900, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVQA777DZDHFLYQSFAUF7LV7WDCXANCNFSM6AAAAAAQTDCPDA . You are receiving this because you were mentioned.Message ID: @.***>