Open shrey-gang opened 5 years ago
I had to merge another PR that moved some stuff around and now your PR conflicts with the master
branch. Can you make sure there are no conflicts?
I have resolved all the conflicts.
@asticode Hi, Apologies for not being active for quite some time. Any update on this one, please. I think all the work is done in this scope. Please let me know if I missed something or there are some more changes required.
@shrey-gang could you resolve conflicts with changes that were made in between ? It seems src/client.js
has conflicts
@shrey-gang could you resolve conflicts with changes that were made in between ? It seems
src/client.js
has conflicts
Conflict resolved
Pull Request is partenered with asticode/go-astilectron#191
This will fix issue: asticode/go-astilectron#190