asticode / astilectron

Electron app that provides an API over a TCP socket that allows executing Electron's method as well as capturing Electron's events
MIT License
285 stars 67 forks source link

Handling unix socket connection based on OS #21

Open shrey-gang opened 5 years ago

shrey-gang commented 5 years ago

Pull Request is partenered with asticode/go-astilectron#191

This will fix issue: asticode/go-astilectron#190

asticode commented 5 years ago

I had to merge another PR that moved some stuff around and now your PR conflicts with the master branch. Can you make sure there are no conflicts?

shrey-gang commented 5 years ago

I have resolved all the conflicts.

shrey-gang commented 3 years ago

@asticode Hi, Apologies for not being active for quite some time. Any update on this one, please. I think all the work is done in this scope. Please let me know if I missed something or there are some more changes required.

asticode commented 3 years ago

@shrey-gang could you resolve conflicts with changes that were made in between ? It seems src/client.js has conflicts

shrey-gang commented 3 years ago

@shrey-gang could you resolve conflicts with changes that were made in between ? It seems src/client.js has conflicts

Conflict resolved