search

asticode / astilectron

Electron app that provides an API over a TCP socket that allows executing Electron's method as well as capturing Electron's events
MIT License
285 stars 67 forks source link

[Draft] Add second instance support #35

Closed NickTikhonov closed 3 years ago

NickTikhonov commented 3 years ago

Adds second instance support according to these instructions.

TODO: test the integration.

NickTikhonov commented 3 years ago

@asticode sure thing - happy to make that refactor once I get the integration working. By the way, what's the recommended way to test a change like this? Will I need to change the bundler also?

asticode commented 3 years ago

By the way, what's the recommended way to test a change like this?

I usually modify the demo just for this occasion (in your case simply add logs on the second instance event), run the bundler with the -a flag (if you run astilectron-bundler -a /path/to/your/local/astilectron/dir it will bind your local source files to your binary), run the binary and checks whether the new is working and the old stuff is still working.

Will I need to change the bundler also?

go.mod will need to be bumped in all repos but I'll take care of it once the PR is merged.

Joe-Improbable commented 3 years ago

I tested this PR, which works fine.

I just pushed a commit that cleans up the JS imports.

Let me know what you think

asticode commented 3 years ago

FYI I've created a v0.42.0 tag

Cheers