Ensure element exists before trying to send message

asticode / astilectron

Electron app that provides an API over a TCP socket that allows executing Electron's method as well as capturing Electron's events

MIT License

285 stars 67 forks source link

Ensure element exists before trying to send message #42

Closed BillyMurrayOlive closed 3 years ago

BillyMurrayOlive commented 3 years ago

If a request is in progress from a window when the window is closed, the response will cause an unhanded javascript exception popup. This PR avoids the unhandled exception by first checking that the element exists before accessing webContents.

asticode commented 3 years ago

FYI I've created a v0.45.0 tag

Cheers