search

asticode / astilectron

Electron app that provides an API over a TCP socket that allows executing Electron's method as well as capturing Electron's events
MIT License
285 stars 67 forks source link

`package.json`'s `version` field isn't up to date #50

Closed frazeradam closed 2 years ago

frazeradam commented 2 years ago

Inspecting the history it appears that it got set at "0.33.0" for v0.33.0, but has not been updated since.

I'd like to suggest that either this be kept up to date, or it be removed and an alternative method of finding the version for an install be provided. Thanks!

asticode commented 2 years ago

Out of curiosity, what problem are you experiencing when this version value is out of sync with the real tag ?

frazeradam commented 2 years ago

We are manually managing the dependencies (astilectron and electron) and are looking to use a similar code pattern to what we use for other files where we check the version, and update it if it's less than the minimum version we need. Since we only plan to keep one version around, we're not including the version number in the folder path.

asticode commented 2 years ago

Version has been updated