search

asticode / go-astilectron-bootstrap

Create a one-window application using Astilectron
MIT License
60 stars 37 forks source link

Support fragment and query string in relative paths #19

Open univac490 opened 3 years ago

univac490 commented 3 years ago

Setting HomePage="index.htm?x=1#xyz results in the app trying to load that file instead of interpreting it as a query string and a fragment. The workaround is to pass an absolute URL with a file scheme, but the app would have to reimplement the logic of creating an absolute path without access to the astilectron.Window.

Adding fragment and query options to astilectron.WindowOptions would fix the problem, but it could be argued that this is a bootstrap issue, since creating an absolute URL when you have access to astilectron.Window is fairly easy as demonstrated by absoluteResourcesPath in this project.

The other option is to add fragment and query to bootstrap.Options and create an absolute URL with a file scheme before creating the window.

asticode commented 3 years ago

@univac490 I understand the problem but I'm not quite understanding the solutions you describe.

Do you mean this line should be replaced by 

url = "file:/" + filepath.Join(absoluteResourcesPath(a, relativeResourcesPath), "app", url)

?