asticode / go-astilectron-bundler

Bundle your Astilectron app with ease
MIT License
129 stars 68 forks source link

Cooperate with other build tools, for example: https://github.com/lunny/gop #3

Closed lunny closed 6 years ago

lunny commented 7 years ago

I used https://github.com/lunny/gop to manage my repos which is not in $GOPATH. Could the bunlder be more flexible to cooperate with this build tool? moved from asticode/go-astilectron#38

asticode commented 7 years ago

@lunny I'd be glad to try it :)

Can you try bundling the demo with the -v flag and tell me at which step it fails by pasting the logs here?

lunny commented 7 years ago

@asticode I have tried the demo. It works well on my macOS.

asticode commented 7 years ago

@lunny do you know what is missing from the bundler to work with https://github.com/lunny/gop then?

lunny commented 7 years ago

Since gop is a compitable tool with go, I think maybe you should let go command configrable.

asticode commented 7 years ago

does gop build allow flags such as -o or -ldflags ?

lunny commented 7 years ago

@asticoe. Yes.

asticode commented 7 years ago

@lunny I've added the go binary path to the configuration. It's available in the go_binary_path key. Is the bundler now working with gop?

asticode commented 7 years ago

@lunny can we consider this issue as fixed?

lunny commented 7 years ago

@asticode sorry, I maybe test this tomorrow.

asticode commented 7 years ago

@lunny no problem, let me know how your tests go

lunny commented 7 years ago

@asticode I have sent #6 and #7, I think maybe I can test my project after that PRs merged.