search

asticode / go-astilectron-bundler

Bundle your Astilectron app with ease
MIT License
129 stars 68 forks source link

info.plist problem #35

Closed lpzgithub closed 5 years ago

lpzgithub commented 5 years ago

On my Mac, bundler Darwin app to release another user. the user's mac run the app fail, he couldn't open the app, but my mac can run it normally. I check the app package and find the Info.plist file like this:

<?xml version="1.0" encoding="UTF-8"?><!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
    <dict>
        <key>CFBundleIconFile</key>
        <string>星际加速.icns</string>
        <key>CFBundleDisplayName</key>
        <string>星际加速</string>
        <key>CFBundleExecutable</key>
        <string>星际加速</string>
        <key>CFBundleName</key>
        <string>星际加速</string>
        <key>CFBundleIdentifier</key>
        <string>com.星际加速</string>
        <key>LSUIElement</key>
        <string>NO</string>
        <key>CFBundlePackageType</key>
        <string>APPL</string>
    </dict>
</plist>

so I modify the Info.plist file like below, add carriage return after xml header.


<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
    <dict>
        <key>CFBundleIconFile</key>
        <string>星际加速.icns</string>
        <key>CFBundleDisplayName</key>
        <string>星际加速</string>
        <key>CFBundleExecutable</key>
        <string>星际加速</string>
        <key>CFBundleName</key>
        <string>星际加速</string>
        <key>CFBundleIdentifier</key>
        <string>com.星际加速</string>
        <key>LSUIElement</key>
        <string>NO</string>
        <key>CFBundlePackageType</key>
        <string>APPL</string>
    </dict>
</plist>

I send the new app to him over again, he can run the app on his mac.

Do you find the problem of Info.plist file?

asticode commented 5 years ago

@lpzgithub I've added the end of line on the master branch.

Could you pull the changes, bundle your app, send it to your friend and confirm this is working?

lpzgithub commented 5 years ago

@asticode bundle my app by the new version, send it to my friend and he can run it normally. thank you. I will close the issue.