search

asticode / go-astilectron-bundler

Bundle your Astilectron app with ease
MIT License
129 stars 68 forks source link

about AppName #66

Open akzhou opened 4 years ago

akzhou commented 4 years ago

Hi, @asticode,I want to package the app, Why the AppName call "Electron" on the top-left screen,"test" on dock, but your demo is right.

` ak@aks-MacBook-Air electron-darwin-amd64 % pwd

/Users/ak/Workspace/zuiyou/test/output/darwin-amd64/test.app/Contents/MacOS/vendor/electron-darwin-amd64

ak@aks-MacBook-Air electron-darwin-amd64 % ls Electron.app
LICENSES.chromium.html LICENSE
version ` //Electron.app ??

bundler.json: { "app_name": "test", "icon_path_darwin": "resources/icon.icns", "icon_path_linux": "resources/icon.png", "icon_path_windows": "resources/icon.ico", "version_astilectron": "0.34.0", "version_electron": "4.0.1", "bind": { "output_path": "core/ark", "package": "ark" } }

akzhou commented 4 years ago

Hi, @asticode,I want to package the app, Why the AppName call "Electron" on the top-left screen,"test" on dock, but your demo is right.

` ak@aks-MacBook-Air electron-darwin-amd64 % pwd

/Users/ak/Workspace/zuiyou/test/output/darwin-amd64/test.app/Contents/MacOS/vendor/electron-darwin-amd64

ak@aks-MacBook-Air electron-darwin-amd64 % ls Electron.app LICENSES.chromium.html LICENSE version ` //Electron.app ??

bundler.json: { "app_name": "test", "icon_path_darwin": "resources/icon.icns", "icon_path_linux": "resources/icon.png", "icon_path_windows": "resources/icon.ico", "version_astilectron": "0.34.0", "version_electron": "4.0.1", "bind": { "output_path": "core/ark", "package": "ark" } }

I found that the AppName value is setted in the main package by default,can I move to another package? may be modify the bundler application to support, configure the bundle.json file

asticode commented 4 years ago

1) make sure you use the latest versions of astilectron, astilectron-bootstrap and astilectron-bundler 2) make sure to go install the latest version of astilectron-bundler 3) remove "version_astilectron": "0.34.0", "version_electron": "4.0.1" from your bundler.json 4) in your go code, add global exported variables like this and use them in your Options like this

tpoxa commented 4 years ago

It's could be just HTML page title tag.