search

asticode / go-astilectron-bundler

Bundle your Astilectron app with ease
MIT License
129 stars 68 forks source link

Replaced the default to be the inputpath rather than the CWD '.' #80

Open radding opened 4 years ago

radding commented 4 years ago

I need this because I am using go modules outside of the GOPATH and my structure is a little different like so: 

/root
  \ cmd
    \ cmd1
      \ main.go
  \ internal
    \gui
      \ ...
bundler.json

Being able to tell the bundler to build ./cmd/cmd1 is useful. THe current implementation doesn't take into account input_path

asticode commented 4 years ago

This makes sense. Could you add a comment above if c.InputPath != "" { explaining why you need it ? That will be useful in the future

radding commented 4 years ago

@asticode Done!

asticode commented 4 years ago

I had forgotten to push last changes to master and your go.sum now conflicts with master's. Could you fetch last changes and not update go.sum ?