search

asticode / go-astilectron

Build cross platform GUI apps with GO and HTML/JS/CSS (powered by Electron)
MIT License
4.9k stars 344 forks source link

window: Add enableRemoteModule flag parameter #290

Closed xplodwild closed 3 years ago

xplodwild commented 3 years ago

As of Electron 10, this field is set to false by default, which means the electron.remote object is not accessible in the browser window. By setting this flag to true, when using Electron 10, this lets you properly access electron.remote, especially for dialogs.

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 79.324% when pulling 3ac95fd87c58aacd3425d7ef0f3b205b8b7377f0 on xplodwild:pr-remote into a6f94fbe952acd110571ada1839458257781a7ef on asticode:master.

asticode commented 3 years ago

I have one question : is astilectron working if enableRemoteModule is set to false ?

xplodwild commented 3 years ago

@asticode Yes, I have a astilectron.sendMessage({name: "minimize"}); call that still works even with enableRemoteModule set to false

asticode commented 3 years ago

OK great.

I've created a v0.19.0 tag.

Cheers