Allow custom electron path

[raboof]

This is useful on systems (like NixOS) where the Electron downloaded by go-astilectron does not work out of the box, but it is possible to install a working Electron separately.

Refs #309

[coveralls]

Coverage decreased (-0.2%) to 79.41% when pulling 0b464bc873eb67022dbdfcf33b0f004297bde98f on raboof:allow-custom-electron-path into 6aa7218e3824c7f63e15995e628c95a8b05afcd2 on asticode:master.

[raboof]

Oops that's an unintentional leftover from the now-rolled-back change. Will add it back - though perhaps it's an indication it should be renamed 'appExecutablePath'?

On 20 February 2021 09:44:46 CET, Quentin Renard notifications@github.com wrote:

@asticode requested changes on this pull request.

@@ -144,7 +148,6 @@ func ElectronDownloadSrc(os, arch, versionElectron string) string { return fmt.Sprintf("https://github.com/electron/electron/releases/download/v%s/electron-v%s-%s-%s.zip", versionElectron, versionElectron, o, a) }

-// initAppExecutable initializes the app executable path

Can you keep this comment?

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/asticode/go-astilectron/pull/311#pullrequestreview-594730125

[asticode]

no worries. I think initAppExecutable is fine for now.

Once you've made the change, can you test running the example in your NixOS and let me know whether this works properly?

[raboof]

Yes, that works!

On 20 February 2021 11:05:43 CET, Quentin Renard notifications@github.com wrote:

no worries. I think initAppExecutable is fine for now.

Once you've made the change, can you test running the example in your NixOS and let me know whether this works properly?

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/asticode/go-astilectron/pull/311#issuecomment-782599371

[asticode]

OK great, just remove the last comment and I'll merge the PR

[asticode]

Cheers

[raboof]

thanks for the detailed directions/feedback!