search

astlinux-project / ddclient-curl

Fork of ddclient using curl for network IO
GNU General Public License v3.0
18 stars 9 forks source link

Implemented configuration for the INWX dyndns2 derivate #10

Closed vicinzu closed 2 years ago

vicinzu commented 4 years ago

I have implemented a configuration for the INWX dyndns derivate. It allows a second GET parameter named "myipv6" containing the ipv6 of the client.

Unfortunately INWX updates the dynamic DNS entries for ipv4 and ipv6 simultaneously. If only one of both is handed over as GET parameter, the IP of the blank one is removed. In order to have both IPv4 and IPv6 entries filled, you update them both in one request.

With this INWX-specific implementation the IPv4 and IPv6 entries can be updated simultaneously.

The nic_inwx_update is a modified version of the nic_dyndns2_update.

abelbeck commented 4 years ago

@Vicinzu : Thanks for the PR, give us a bit of time to look it over. @dkerr64

vicinzu commented 4 years ago

@abelbeck , @dkerr64 : Thanks for checking the PR. Do you have an update?

abelbeck commented 4 years ago

Sorry, not yet.

dkerr64 commented 4 years ago

I've looked at the code and the changes to nic_dyndns2_update are minimal, all you do is add the ability to update an IPv6 address. So my question is why create a whole new function and not just add IPv6 support to the nic_dyndns_update function -- which would make it available to any of the other services that use the same protocol?

vicinzu commented 4 years ago

@dkerr64 Corrrect. I was afraid of changing nic_dyndns2_update, because it is so widely used and i have not so much practice with perl.