search

astoeckel / femtosip

Minimal Python SIP implementation ringing phones as a door bell replacement
GNU Affero General Public License v3.0
48 stars 15 forks source link

Timeout while waiting for server response #4

Closed m-kloeckner closed 1 year ago

m-kloeckner commented 3 years ago

First off: Thank you very much for developing this! I'm using your script for a few months now to trigger my home office phone when someone is at the door. It's very reliable.

I only had to make a small adjustment in line 503. My old Gigaset S685IP is not responding fast enough, so 1s timeout was too low. Should this be just increased or should this be made configurable?

https://github.com/astoeckel/femtosip/blob/dab4b59c939a361f9201cc82fcc0d328c80be6aa/femtosip.py#L503-L504

astoeckel commented 3 years ago

Thank you for your feedback, glad to hear that you found it useful!

I agree that the 1.0 second timeout is too low. Optimally, this would be configurable with a default of about 5.0 to 10.0 seconds, I guess.

tobwen commented 1 year ago

Raising this value also makes it work with my Asterisk PBX. I think about exposing it to a switch.

astoeckel commented 1 year ago

This has been fixed by the PR referenced above.