astoff / code-cells.el

Emacs utilities for code split into cells, including Jupyter notebooks
GNU General Public License v3.0
190 stars 12 forks source link

Change the default face for cell separators #6

Closed memeplex closed 3 years ago

memeplex commented 3 years ago

This default:

code-cells-header-line '((t :extend t :inherit header-line))

is rather problematic:

  1. It makes difficult to tell windows from cells inside a window.
  2. Flashy visual bells may be applied when errors are reported.

https://user-images.githubusercontent.com/2845433/137003476-4fb1fcea-3b76-4edf-8848-69153e99c489.mov

What do you think of

code-cells-header-line '((t :underline t :extend t :inherit font-lock-comment-face)

image

Looks pretty cool to me and I believe it's a safer default.

astoff commented 3 years ago

Looks better indeed, but what do you think of an overline instead? To me the comment marker is part of the cell, so it makes sense to put the division above it.

memeplex commented 3 years ago

That works for me also.

memeplex commented 3 years ago

To me the comment marker is part of the cell, so it makes sense to put the division above it.

This makes sense. I was thinking of the text as a title to underline, but many times there is no text at all, so your suggestion is better.