search

astoff / devdocs.el

Emacs viewer for DevDocs
279 stars 16 forks source link

Allow devdocs buffers to be bookmarked #36

Open aepyornis opened 3 months ago

aepyornis commented 3 months ago

This does what is asked by #32. Using bookmark-set from the devdocs buffer will store that current page.

astoff commented 3 months ago

This looks great! Since devdocs.el is on ELPA, you'd need the FSF copyright assignment — do you have it?

aepyornis commented 3 months ago

ah nope, but send me the instructions I can do that.

astoff commented 3 months ago

@aepyornis Here are some instructions: https://git.savannah.gnu.org/cgit/gnulib.git/plain/doc/Copyright/request-assign.future And here is an explanation of why the FSF asks for this: https://www.gnu.org/licenses/why-assign.html

You can also ask on the Emacs mailing list emacs-devel@gnu.org for more information. I hope it works out for you :-).

aepyornis commented 3 months ago

Thanks! Oh wow, didn't realize the paperwork involved :) Hopefully I'll get it sorted soon...

jdtsmith commented 1 month ago

Any progress here? Would be great to have devdocs bookmark able (e.g. for use with activities).

aepyornis commented 1 month ago

Ah sorry, my employer hasn't signed the proper disclosure form, so I haven't recieved FSF copyright assignment. but if it were up to me, I consider this code to be in the public domain so we can start bookmarking devdocs :)

astoff commented 4 weeks ago

I feel we wouldn't be violating the spirit of the idea that tiny changes don't need copyright assignment, but the criterium is that those should be under 15 lines of code. If you remove commentary and linter-appeasement and spacious formatting I think the PR would fit in that quota.